Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Subject: Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding
Date: 2026-10-20 19:41:46
Message-ID: 1388770.1792525306@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

shihao zhong <zhong950419(at)gmail(dot)com> writes:
> Cool. v9 does what you suggested, equal encodings plus
> pg_encoding_verifymbstr.

Hmm, I wonder why we can't use this same logic on Windows? ISTM
that we've removed the need to guess what gettext() thinks it's doing,
so the fact that that guessing is harder on Windows is no longer a
factor. I'd just as soon not summarily disable translation on
Windows.

> Fixing the WIN1252 validator would be master only. I want to focus
> on 19 stability until GA, and I can look at it after that.

Agreed.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Iliia Khaprov 2026-10-20 19:46:11 Re: [PATCH] Remove useless ORDER BY from scalar subqueries
Previous Message Tom Lane 2026-10-20 19:15:57 Re: query_int wrongly parses zero-padded input