Re: [PATCHES] Infrastructure changes for recovery

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Infrastructure changes for recovery
Date: 2008-10-07 14:08:47
Message-ID: 13866.1223388527@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> A patch specifically marked as "required for other work" has been
> delayed by more than 5 weeks on queue and nobody was ever assigned to
> review it. That was exactly the problem CommitFests were supposed to
> resolve and from my perspective this is a systemic failure.

To be blunt, that patch spent most of September in "waiting for author"
state. Looking in the archives, I see that

* Original patch was posted on 31-Aug.

* I reviewed that patch on 8-Sep.

* You posted a revised patch on 10-Sep, but it was explicitly marked
as not ready to be actioned.

* It was not until 23-Sep that a patch was posted that you stated
you were happy with.

* I reviewed that one on 25-Sep.

* The patch now in the queue was posted on 30-Sep (all of 8 minutes
before midnight).

I don't see any systemic failure here.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-10-07 14:11:53 Re: Reducing some DDL Locks to ShareLock
Previous Message Zdenek Kotala 2008-10-07 14:05:36 doubts about toast_flatten_tuple_attribute/heap_form_tuple

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2008-10-07 14:27:17 Re: [PATCHES] Infrastructure changes for recovery
Previous Message Simon Riggs 2008-10-07 12:50:38 Re: Subtransaction commits and Hot Standby