From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Default monitoring roles |
Date: | 2017-03-30 19:27:23 |
Message-ID: | 13861.1490902043@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> On 30 March 2017 at 19:31, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>> The buildfarm is showing red (the same errors that I get...):
>> pgrowlocks.c: In function ‘pgrowlocks’:
>> pgrowlocks.c:105:65: error: expected ‘)’ before ‘;’ token
>> is_member_of_role(GetUserId(), DEFAULT_ROLE_STAT_SCAN_TABLES);
> Weird. make check-world just skipped that directory. I guess for Dave also.
If you just did check-world, it probably didn't build contrib modules that
don't have tests, because the "check" target wouldn't do anything without
tests to run.
AFAICS, there isn't any top-level make target that will build all of
contrib except "make world", which also builds the docs and therefore
isn't very fast. I wonder if we should create some more convenient
testing target that builds all code but not the docs.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-30 19:36:39 | Re: pgsql: Default monitoring roles |
Previous Message | Simon Riggs | 2017-03-30 18:57:29 | Re: pgsql: Default monitoring roles |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2017-03-30 19:29:32 | Re: New CORRESPONDING clause design |
Previous Message | Aleksander Alekseev | 2017-03-30 19:27:06 | Re: WIP: Covering + unique indexes. |