Re: Thread-unsafe coding in ecpg

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Thread-unsafe coding in ecpg
Date: 2019-01-21 17:09:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> writes:
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
>> So like this ...

> How quick! Thank you. I've reviewed the code for both Unix and Windows, and it looks OK. I haven't built the patch, but expect the buildfarm to do the test.

Thanks for reviewing! I've pushed this now (to HEAD only for the moment),
we'll see what the buildfarm thinks.

BTW, I found another spot in descriptor.c where ecpglib is using
setlocale() for the same purpose. Perhaps that one's not reachable
in threaded apps, but I didn't see any obvious reason to think so,
so I changed it too.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Nishant, Fnu 2019-01-21 17:09:38 Re: possible deadlock: different lock ordering for heap pages
Previous Message Joshua D. Drake 2019-01-21 17:07:56 Re: House style for DocBook documentation?