Re: [PATCH] configure: allow adding a custom string to PG_VERSION

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Oskari Saarenmaa <os(at)ohmu(dot)fi>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] configure: allow adding a custom string to PG_VERSION
Date: 2013-11-19 01:48:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, 2013-11-05 at 18:29 +0200, Oskari Saarenmaa wrote:
> This can be used to tag custom built packages with an extra version string
> such as the git describe id or distribution package release version.

I think this is a reasonable feature, and the implementation is OK, but
I don't see why the format of the extra version information needs to be


I'd imagine, for example, that someone will want to do -something or
+something. So I'd just make this



> +# Allow adding a custom string to PG_VERSION
> +PGAC_ARG_REQ(with, extra-version, [NAME], [extra version information],

This could be indented better. It was a bit confusing at first.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2013-11-19 01:58:50 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE
Previous Message Josh Berkus 2013-11-19 01:20:38 Re: More legacy code: pg_ctl