Re: Fw: [COMMITTERS] pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fw: [COMMITTERS] pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value
Date: 2013-11-09 23:34:32
Message-ID: 1384040072.74454.YahooMailNeo@web162903.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:

>> I distilled it down to the simplest case I could find which
>> failed to produce the warning; attached. Do you agree that it is
>> a compiler bug that this generates no warning?

>> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
>> -Wdeclaration-after-statement -Wendif-labels
>> -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
>> -fwrapv -fexcess-precision=standard -g -D_GNU_SOURCE -c -o
>> warning_test.o warning_test.c -MMD -MP

The actual test case I sent for gcc is what is attached here.
Sorry for attaching the wrong file before.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
warning_test.c text/x-csrc 363 bytes

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2013-11-10 00:14:05 pgsql: Fix ECPG compiler warning.
Previous Message Kevin Grittner 2013-11-09 22:17:13 Re: Fw: [COMMITTERS] pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-11-09 23:47:33 Re: Race condition in b-tree page deletion
Previous Message Andres Freund 2013-11-09 22:42:13 Re: logical changeset generation v6.5