Re: BUG #19826: corr()/regr_r2() of constant input: NULL serially, 1 with partial aggregation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Venu K <venu2805k(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19826: corr()/regr_r2() of constant input: NULL serially, 1 with partial aggregation
Date: 2026-11-03 03:03:47
Message-ID: 1382078.1793675027@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Venu K <venu2805k(at)gmail(dot)com> writes:
> Attached is a patch for master.

Hm, the actual bug report hasn't come through yet, but I gather your
point is that float8_regr_combine hasn't gotten the word about the
efforts we've made in float8_regr_accum to avoid roundoff error for
all-the-same inputs. Good point, but isn't it also missing the latter
routine's recently-added logic for forcing outputs to NaN when
necessary?

Also, TBH, the proposed comments read like AI slop; they don't
address any of the questions I had on first reading the patch.
Some more effort seems appropriate there.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message shihao zhong 2026-11-03 03:29:24 Re: data race in libpq process-global variables (static_client_encoding / static_std_strings) when connections are established concurrently
Previous Message Fujii Masao 2026-11-03 01:56:16 Re: Lost walsender wakeup stalls synchronous commits until the standby's next reply (16+)