Re: message string fixes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: message string fixes
Date: 2008-01-20 21:54:54
Message-ID: 13811.1200866094@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
> There is a fallback to regex if expression isn't supported by regis (see call
> of RS_isRegis() in spell.c).

Oh. So in that case, the messages Alvaro is worried about

ereport(ERROR,
(errcode(ERRCODE_INVALID_REGULAR_EXPRESSION),
errmsg("invalid regis pattern: \"%s\"",
str)));

aren't user-facing errors at all, and should be demoted to elog's,
correct?

elog(ERROR, "invalid regis pattern: \"%s\"", str);

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2008-01-20 22:00:33 Re: Minor bug in src/port/rint.c
Previous Message Tom Lane 2008-01-20 21:47:54 Re: Minor bug in src/port/rint.c