Re: plpgsql: variables of domain of composite types are not correctly initialized

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> I got a bug report for plpgsql_check related to domains of composite types.
> While I played with code, maybe I found a bug:

Indeed. Looks like exec_stmt_return's special case for a simple
variable reference forgets to fill estate->rettype when the variable
is a null record. This is an old bug, but I think we'd managed not
to notice because that value isn't consulted unless we have to cast
to a domain.

The behavior we want is what exec_eval_datum does, and after looking
at it for a minute I wondered why we don't just use exec_eval_datum
instead of duplicating logic. The ROW case already does that, so
we can fix the bug with strictly less code.

regards, tom lane