From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Eliminating pg_catalog.pg_rewrite.ev_attr |
Date: | 2013-09-04 17:51:57 |
Message-ID: | 1378317117.39500.YahooMailNeo@web162903.mail.bf1.yahoo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Shouldn't attribute_used() be removed from rewriteManip.h?
Yeah, I don't know how I missed that. Thanks.
> I was a bit surprised by your removal of the
> rangeTableEntry_used() test in the hunk at
> rewriteHandler.c:1273ff. That's probably all right, but it takes
> this out of the realm of a mechanical change.
[ also questioned by Álvaro ]
I'll leave that as it was -- it can be discussed separately from
the mechanical changes.
New patch attached.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
rule-attr-removal-v2.patch | text/x-diff | 11.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2013-09-04 17:56:04 | Re: ENABLE/DISABLE CONSTRAINT NAME |
Previous Message | Andres Freund | 2013-09-04 16:55:46 | Re: [9.4] Make full_page_writes only settable on server start? |