From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, mathias(at)brossard(dot)org, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: ToDo: show size of partitioned table |
Date: | 2019-03-14 02:19:16 |
Message-ID: | 137433b4-43e3-4c37-1f70-28b76d781012@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019/03/14 2:11, Pavel Stehule wrote:
> st 13. 3. 2019 v 8:02 odesílatel Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
> napsal:
>> Not a native speaker either, but I like Justin's changes. Although I
>> noticed that he missed changing one sentence to look like other similar
>> sentences.
>>
>> What Justin did:
>>
>> - indexes) and associated description are also displayed.
>> + indexes) is displayed, as is the relation's description.
>> </para>
>>
>> What I think he meant to do:
>>
>> - indexes) and associated description are also displayed.
>> + indexes) is also displayed, along with the associated description.
>> </para>
>>
>>
>>> I am not sure if we use labels in form "some: detail" somewhere.
>>
>> I haven't seen column names like that either. How about:
>>
>> - gettext_noop("Direct partitions size"));
>> + gettext_noop("Leaf partition size"));
>>
>> - gettext_noop("Total partitions size"));
>> + gettext_noop("Total size"));
>>
>> - gettext_noop("Partitions size"));
>> + gettext_noop("Total size"));
>>
>
> +1
>
> Pavel
>
>
>> I've attached v11 of the patch, which merges most of Justin's changes and
>> some of my own on top -- documentation and partition size column names.
Maybe, we should set this ready for committer then?
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Tsunakawa, Takayuki | 2019-03-14 02:20:03 | RE: Timeout parameters |
Previous Message | Tom Lane | 2019-03-14 01:57:13 | Re: Using the return value of strlcpy() and strlcat() |