| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | "PostgreSQL-development Hackers" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch |
| Date: | 2007-09-26 23:33:03 |
| Message-ID: | 13737.1190849583@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> [ revised version of tuptoaster-fixup.patch ]
I've applied most of this. I didn't like the hardwired assumption about
minimum size to compress, and anyway you had put it in a place where it
broke the intended behavior for SET STORAGE PLAIN. I replaced it with
just a test to save palloc/pfree overhead in toast_compress_datum, which
has at least got knowledge of which PGLZ strategy is being used.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian G. Pflug | 2007-09-27 00:29:17 | Re: [FEATURE REQUEST] Streaming Onlinebackup (Maybe OFFTOPIC) |
| Previous Message | Kevin Grittner | 2007-09-26 23:09:55 | Re: [FEATURE REQUEST] Streaming Onlinebackup (Maybe OFFTOPIC) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-09-27 05:23:07 | Re: Minor changes to Recovery related code |
| Previous Message | Tom Lane | 2007-09-26 22:38:24 | Re: Minor recovery changes |