From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgwin32_open returning EINVAL |
Date: | 2007-11-29 15:37:30 |
Message-ID: | 13733.1196350650@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Magnus Hagander wrote:
>>> Maybe. I'm concerned we might end up logging a whole lot more, for cases
>>> where it's not an actual error.
I'm very concerned about that too, and think that DEBUG5 is just fine.
> Hmm, I just noticed a bug in those fprintf calls -- they are missing
> the terminating newline. Please change that too if you're going to
> patch this part of the code. In order to avoid translation problems, I
> think it should be like this:
> fprintf(stderr, _("mapped win32 error code %lu to %d" "\n"), e, errno);
That's both unreadable and useless, because gettext will smash it to one
string anyway.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-11-29 15:45:51 | Re: Time to update list of contributors |
Previous Message | Robert Treat | 2007-11-29 15:32:28 | Re: Time to update list of contributors |