bool abuse in path_encode()

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: bool abuse in path_encode()
Date: 2013-07-07 01:12:33
Message-ID: 1373159553.17986.7.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The function path_encode() in geo_ops.c takes an argument "bool closed",
to indicate an open or closed path --- but you can also pass -1 to
indicate "neither". I propose to change this to an enum to make the
code clearer and less weird.

Attachment Content-Type Size
path-encode-enum.patch text/x-patch 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robins Tharakan 2013-07-07 03:25:51 Re: Add regression tests for ROLE (USER)
Previous Message Kenji uno 2013-07-07 01:00:16 How to implement Gin method?