Re: Eliminating PD_ALL_VISIBLE, take 2

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Eliminating PD_ALL_VISIBLE, take 2
Date: 2013-06-10 05:17:32
Message-ID: 1370841452.7746.29.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, 2013-05-30 at 10:07 -0700, Jeff Davis wrote:
> > Come to think of it, even without the torn page & checksum issue, do we
> > really want to actively clear the all-visible flags after upgrade?

Removed that from the patch and rebased. I think the best approach is to
remove the bit opportunistically when we're already dirtying the page
for something else.

However, right now, there is enough skepticism of the general approach
in this patch (and enough related proposals) that I'll leave this to be
resolved if and when there is more agreement that my approach is a good

Also, it could use another round of performance testing before it's
actually commitable.

Jeff Davis

Attachment Content-Type Size
rm-pd-all-visible-20130609.patch text/x-patch 69.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-06-10 05:28:10 Re: pg_filedump 9.3: checksums (and a few other fixes)
Previous Message Jeff Davis 2013-06-10 05:00:44 pg_filedump 9.3: checksums (and a few other fixes)