| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Florian Pflug <fgp(at)phlo(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq. |
| Date: | 2010-06-24 15:15:23 |
| Message-ID: | 13617.1277392523@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Florian Pflug <fgp(at)phlo(dot)org> writes:
> On Jun 24, 2010, at 16:45 , Robert Haas wrote:
>> I think the existing names are fine - people should understand that
>> "options" means "server-side options" and that anything else is a
>> client-side option. However, if there's a strong consensus the other
>> way and someone feels like working up a patch, that's fine too.
> I'd volunteer to create the patch if people think renaming the libpq options is a good idea.
I'm with Robert: the names are fine as-is. We've not had complaints
about the libpq SSL parameters being confusingly like server-side SSL
parameters, for instance.
It might be a good idea to add a sentence to the documentation, though,
just pointing out that these control client-side keepalive probes rather
than server-side.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-06-24 16:40:45 | pgsql: Add stray "else" that seems to have gone missing. |
| Previous Message | Florian Pflug | 2010-06-24 15:08:58 | Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Carsten Kropf | 2010-06-24 15:36:51 | Re: TOAST issue on custom index access method |
| Previous Message | Florian Pflug | 2010-06-24 15:08:58 | Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq. |