Re: Cryptohash OpenSSL error queue in FIPS enabled builds

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Cryptohash OpenSSL error queue in FIPS enabled builds
Date: 2022-04-25 22:44:18
Message-ID: 135967.1650926658@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> In this particular codepath I think we can afford clearing it on the way out,
> with a comment explaining why.

Yeah. It seems out of the ordinary for an OpenSSL call to stack
two error conditions, so treating a known case of that specially
seems reasonable. Patches seem sane from here.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-04-26 01:01:20 Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
Previous Message Tomas Vondra 2022-04-25 22:30:21 Re: bogus: logical replication rows/cols combinations