Re: Enabling Checksums

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Enabling Checksums
Date: 2013-01-17 01:38:38
Message-ID: 1358386718.1953.6.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

New version of checksums patch.

* rebased
* removed two duplicate lines; apparently the result of a bad merge
* Added heap page to WAL chain when logging an XLOG_HEAP2_VISIBLE to
avoid torn page issues updating PD_ALL_VISIBLE. This is the most
significant change.
* minor comment cleanup

No open issues that I'm aware of with the patch itself.

Greg appears to have made some progress on the automated corruption

Note to reviewers: I also have a patch out to remove PD_ALL_VISIBLE
entirely. The code around PD_ALL_VISIBLE is quite tricky (with or
without this patch), so if the PD_ALL_VISIBLE patch is committed first
then it will make reviewing this patch easier. Regardless, the second
patch to be committed will need to be rebased on top of the first.

Jeff Davis

Attachment Content-Type Size
replace-tli-with-checksums-20130116.patch.gz application/x-gzip 8.8 KB
checksums-20130116.patch.gz application/x-gzip 18.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-01-17 01:45:00 Re: log_lock_waits to identify transaction's relation
Previous Message Tatsuo Ishii 2013-01-17 01:35:08 Re: review: pgbench - aggregation of info written into log