From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Assert for frontend programs? |
Date: | 2012-12-16 06:32:24 |
Message-ID: | 1355639544.4311.3.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 2012-12-14 at 15:32 -0500, Andrew Dunstan wrote:
> Here's a patch for that.
It appears that your change has caused new compiler warnings:
encnames.c:9:1: warning: "Assert" redefined
In file included from encnames.c:8:
../../../src/include/postgres_fe.h:36:1: warning: this is the location of the previous definition
wchar.c:10:1: warning: "Assert" redefined
In file included from wchar.c:9:
../../../src/include/postgres_fe.h:36:1: warning: this is the location of the previous definition
encnames.c:9:1: warning: "Assert" redefined
In file included from encnames.c:8:
../../../src/include/postgres_fe.h:36:1: warning: this is the location of the previous definition
> I changed some of the psql assertions so they
> all have explicit boolean expressions - I think that's better style for
> use of assert.
I think not, but I probably wrote most of that originally.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2012-12-16 06:37:50 | multiple CREATE FUNCTION AS items for PLs |
Previous Message | Peter Eisentraut | 2012-12-16 06:29:47 | Re: Assert for frontend programs? |