Re: Multiple --table options for other commands

From: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Multiple --table options for other commands
Date: 2012-12-13 06:35:14
Message-ID: 1355380514.26790.10@mofo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Josh,

The good news is that there's only this little bit of
documentation formatting to fix....

On 12/12/2012 11:04:53 PM, Josh Kupershmidt wrote:
> On Wed, Dec 12, 2012 at 8:14 AM, Karl O. Pinc <kop(at)meme(dot)com> wrote:
> > On 12/11/2012 10:25:43 PM, Josh Kupershmidt wrote:
> >> On Tue, Dec 11, 2012 at 11:46 AM, Karl O. Pinc <kop(at)meme(dot)com>
> wrote:
> >> >> I believe you need ellipses behind --table in the syntax
> summaries
> >> >> of the command reference docs.

> > Yes. I see. I didn't look at all the command's reference pages
> > but did happen to look at clusterdb, which does have --table
> > in the syntax summary. I just checked and you need to fix
> > clusterdb, reindexdb, and vacuumdb.
>
> OK, I made some changes to the command synopses for these three
> commands. For some reason, reindexdb.sgml was slightly different from
> the other two, in that the --table and --index bits were underneath a
> <group> node instead of <arg>. I've changed that one to be like the
> other two, and made them all have:
> <arg choice="opt" rep="repeat">
>
> to include the ellipses after the table -- I hope that matches what
> you had in mind.

Sadly, the ... is in the wrong place in all 3. Yours looks like (for
2 examples):

vacuumdb [connection-option...] [option...] [ --table | -t table
[( column [,...] )] ...] [dbname]

reindexdb [connection-option...] [ --table | -t table ...] [ --index |
-i index ...] [dbname]

I want the ... outside the square braces, because the --table (or -t)
must repeat for each table specified. Like:

vacuumdb [connection-option...] [option...] [ --table | -t table
[( column [,...] )] ]... [dbname]

reindexdb [connection-option...] [ --table | -t table ]... [ --index |
-i index ]... [dbname]

Sorry, I don't see any examples in the existing docs of how this is
done.

It seems like what you have should work, although perhaps
somehow that's the difference between the <arg> and <group>
and you need to switch them back to how reindex used to
be. Otherwise, there's the docs at docbook.org, and
the docbook mailing lists. Or maybe the stylesheets
are broken. (Always blame the tool! It's never _our_
fault! ;-)

Have you had trouble getting this to work?
Maybe someone who knows what they're doing will step
in and give us the answer.

Regards,

Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-12-13 09:31:39 Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader
Previous Message Josh Kupershmidt 2012-12-13 05:04:53 Re: Multiple --table options for other commands