Re: [HACKERS] CIDR/INET improvements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Joachim Wieland <joe(at)mcknight(dot)de>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] CIDR/INET improvements
Date: 2006-01-24 04:30:58
Message-ID: 13552.1138077058@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Patch for testing attached.

This is an utterly bad idea, because it not only doesn't address the
problem (ie, confusion about whether inet and cidr are distinct types
or not), but it masks mistakes in that realm by hiding data on output.
It'll be almost impossible to debug situations where x is different
from y but they display the same.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alon Goldshuv 2006-01-24 07:57:18 Re: Libpq COPY optimization
Previous Message Jeroen T. Vermeulen 2006-01-24 04:29:13 Re: ROLLBACK triggers?

Browse pgsql-patches by date

  From Date Subject
Next Message Alon Goldshuv 2006-01-24 08:02:20 Libpq COPY optimization patch
Previous Message Bruce Momjian 2006-01-24 04:15:47 Re: [HACKERS] CIDR/INET improvements