Re: pgsql: Add psql option: -1 or --single-transaction

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add psql option: -1 or --single-transaction
Date: 2006-02-14 14:35:13
Message-ID: 13551.1139927713@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> On Tue, 2006-02-14 at 16:55 +0800, Christopher Kings-Lynne wrote:
>> Huh? But it'll cause a total failure of dump restore?

> Perhaps you can explain further?

As the code stands, a restore involving blobs plus --single-transaction
produces
BEGIN;
...
BEGIN;
...
COMMIT;
...
COMMIT;
which does *not* have the intended behavior because BEGIN does not nest.
This is a must-fix, else we may as well revert the patch entirely,
because it does not work.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2006-02-14 14:49:34 Re: pgsql: Add psql option: -1 or --single-transaction
Previous Message User Fxjr 2006-02-14 13:29:14 npgsql - Npgsql2: Imported Sources