Re: pg_upgrade problem with invalid indexes

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_upgrade problem with invalid indexes
Date: 2012-12-07 01:37:28
Message-ID: 1354844248.4530.162.camel@sussancws0025
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2012-12-06 at 20:05 -0500, Andrew Dunstan wrote:
> I think I prefer the first suggestion. If they are trying to upgrade
> when there's an invalid index presumably they aren't aware of the
> invalidity (or they would have done something about it). It would be
> better to fail and make them fix or remove the index, ISTM.

I'm a little concerned about introducing extra causes of failure into
upgrade when we don't have to. They could have gone on with that invalid
index forever, and I don't see it as the job of upgrade to alert someone
to that problem.

That being said, it's a reasonable position, and I am fine with either
approach.

Regards,
Jeff Davis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2012-12-07 01:49:22 Re: Commits 8de72b and 5457a1 (COPY FREEZE)
Previous Message Jeff Davis 2012-12-07 01:31:09 Re: Commits 8de72b and 5457a1 (COPY FREEZE)