| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, "Adam, Etienne (Nokia-TECH/Issy Les Moulineaux)" <etienne(dot)adam(at)nokia(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>, "Duquesne, Pierre (Nokia-TECH/Issy Les Moulineaux)" <pierre(dot)duquesne(at)nokia(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [postgresql 10 beta3] unrecognized node type: 90 |
| Date: | 2017-08-28 14:47:58 |
| Message-ID: | 13540.1503931678@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Mon, Aug 28, 2017 at 6:34 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> If what you're complaining about is that I put back the "if
>> (outerPlan->chgParam == NULL)" test to allow postponement of the
>> recursive ExecReScan call, I'm afraid that it's mere wishful
>> thinking that omitting that test in nodeGather did anything.
> Previously outerPlan->chgParam will be NULL, so I think rescan's won't
> be postponed.
That seems like an unacceptably fragile assumption. Even if it happens to
be true today, we would need to fix it sooner or later. (And I kinda
suspect it's possible to break it today, anyway. Treating PARAM_EXEC
Params as parallel-restricted seems to lock out the easiest cases, but we
have param slots that don't correspond to any Param node, eg for recursive
union worktables. replace_nestloop_params is also a source of PARAM_EXEC
Params that won't be detected during is_parallel_safe() tests, because it
happens later.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yaser Raja | 2017-08-28 15:42:33 | Gin Index Creation Failure |
| Previous Message | Amit Kapila | 2017-08-28 14:05:29 | Re: [HACKERS] [postgresql 10 beta3] unrecognized node type: 90 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrien Nayrat | 2017-08-28 15:46:48 | Re: auto_explain : log queries with wrong estimation |
| Previous Message | Ryan Murphy | 2017-08-28 14:31:16 | Re: 1 test fails in make installcheck-world - database "regress_ecpg_user2" does not exist |