| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, andrewbille(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables. |
| Date: | 2025-10-16 01:47:52 |
| Message-ID: | 1349119.1760579272@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Thu, 16 Oct 2025 at 14:31, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm confused by all the extraneous changes in this?
> It includes the query rewrite too in order to get rid of the
> subqueries in the targetlist to pg_attribute.
Ah, I've not reviewed that bit.
> We could just do the conditional calling of
> the pg_get_*def() functions, but performance would still be terrible
> for ignore_system_indexes=on due to the Seq Scans, and slightly worse
> overall.
Got it. Definitely looks promising, but I'm too tired to review
the whole change.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-10-16 01:53:07 | Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c |
| Previous Message | David Rowley | 2025-10-16 01:36:23 | Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables. |