Re: pg_upgrade tests vs alter generic changes

Excerpts from Tom Lane's message of sáb sep 29 14:57:11 -0300 2012:
>
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:

> > Well, that's a very good point. chough is actually the same machine,
> > doing an MSVC build. So why would this test pass there? I'll investigate
> > a bit more. Here's what the regression diffs look like when run from
> > pg_upgrade on pitta:
>
> > ALTER COLLATION alt_coll1 RENAME TO alt_coll3; -- OK
> > ! ERROR: collation "alt_coll1" for encoding "SQL_ASCII" does not exist
>
> vs
>
> > ALTER COLLATION alt_coll1 RENAME TO alt_coll3; -- OK
> > ! ERROR: collation "alt_coll1" for encoding "WIN1252" does not exist
>
> Oh! So Alvaro's second expected file is assuming that machines without
> custom-locale support will only ever be testing with SQL_ASCII encoding.
> Wrong.
>
> At this point I'm inclined to think that we should just drop the
> collation-specific portions of the alter_generic test. It looks to me
> like making that adequately portable is going to be far more trouble
> than it's worth.

Ah, yes. We already dropped some plperl tests because of a similar
problem. I will remove that part of the test.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services