Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section
Date: 2018-05-03 17:11:28
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Thank you, pushed!

Stas Kelvich wrote:
> Hello.
> It seems that during COMMIT PREPARED FinishPreparedTransaction() doesn't
> hold interrupts around writing to wal and cleaning up ProcArray and GXact
> entries. At least RemoveTwoPhaseFile (which is called in between) can print
> a warning with ereport(), which, in turn will check for interrupts and
> therefore can cancel backend or throw an error before GXact clean-up.
> Other similar places like CommitTransaction and PrepareTransaction have
> such hold interrupts sections.
> --
> Stas Kelvich
> Postgres Professional:
> The Russian Postgres Company

Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-05-03 17:16:29 Re: Python 3.7 support
Previous Message Stas Kelvich 2018-05-03 17:11:26 Re: Global snapshots