Re: Add %z support to elog/ereport?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add %z support to elog/ereport?
Date: 2014-01-23 16:14:05
Message-ID: 13452.1390493645@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> So, here's a patch adding %z support to port/snprintf.c including a
> configure check to test whether we need to fall back.

OK, I'll take a look.

> I am not too
> happy about the runtime check as the test isn't all that meaningful, but
> I couldn't think of anything better.

Yeah, it's problematic for cross-compiles, but no more so than configure's
existing test for "%n$" support. In practice, since both these features
are required by C99, I think it wouldn't be such an issue for most people.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-01-23 16:17:47 Re: Add %z support to elog/ereport?
Previous Message Florian Pflug 2014-01-23 16:13:16 Passing "direct" args of ordered-set aggs to the transition function