Re: duplicate function oid symbols

John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
>> Ok, here is a patch to fix that, and also throw an error if pg_proc.dat
>> has an explicitly defined symbol.

> It occurred to me I neglected to explain the error with a comment, which
> I've added in v2.

Pushed with a bit of tweaking of the error message.

I wondered about introducing a similar prohibition for pg_type.
The only existing oid_symbol in pg_type that I think has enough
grandfather status to be tough to change is CASHOID for "money".
But we could imagine special-casing that with a handmade macro

#define CASHOID MONEYOID

and then getting rid of the oid_symbol entries. (Or perhaps we
could just up and nuke CASHOID too? It's somewhat dubious that
any outside code is really using that macro.)

May not be worth the trouble, but if we're anal enough to do this
patch maybe we should do that too.

regards, tom lane