Re: [PoC] Federated Authn/z with OAUTHBEARER

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Ivan Kush <ivan(dot)kush(at)tantorlabs(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, lev(dot)nikolaev(at)tantorlabs(dot)com
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Date: 2025-07-09 19:42:30
Message-ID: 1342154.1752090150@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> On Wed, Jul 9, 2025 at 12:07 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm confused about why this moves up the temporary changes of
>> CPPFLAGS and LDFLAGS, but not LIBS? Maybe that's actually correct,
>> but it looks strange (and perhaps deserves a comment about why).

> Does the attached help clarify?

Yes, thanks.

> (Upthread, I was idly wondering if those AC_CHECKs should just be
> removed -- after all, PKG_CHECK_MODULES just told us where Curl was --
> but I'm nervous that this might make more niche use cases like
> cross-compilation harder to use in practice?)

Nah, let's keep them. We do document for at least some libraries
how to manually specify the include and link options without
depending on pkg-config. If someone tries that with libcurl,
it'd be good to have sanity checks on the results.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-07-09 19:46:43 Re: TransactionIdIsActive() has long been unused
Previous Message Andres Freund 2025-07-09 19:42:26 Re: Adding basic NUMA awareness