| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CREATE FOREGIN TABLE LACUNA |
| Date: | 2012-07-12 21:00:27 |
| Message-ID: | 1342126827.19702.6.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On lör, 2012-06-23 at 23:08 +0100, Dean Rasheed wrote:
> I spotted a couple of other issues during testing:
>
> * You're still allowing INCLUDING DEFAULTS and INCLUDING STORAGE, even
> though these options are not supported on foreign tables.
>
> * If I do INCLUDING ALL, I get an error because of the unsupported
> options. I think that "ALL" in this context needs to be made to mean
> all the options that foreign tables support (just COMMENTS at the
> moment).
Note that when I added CREATE TABLE LIKE to support composite types, it
was decided to ignore non-applicable options (like copying indexes from
types or views etc.). The same should be done here, unless we have
reasons to revise the earlier decision.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2012-07-12 21:08:59 | Re: compiler warnings on the buildfarm |
| Previous Message | Peter Eisentraut | 2012-07-12 20:57:17 | sign mismatch in walreceiver.c |