Re: SP-GiST for ranges based on 2d-mapping and quad-tree

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SP-GiST for ranges based on 2d-mapping and quad-tree
Date: 2012-07-03 14:26:08
Message-ID: 1341325568.6857.18.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2012-07-02 at 23:47 -0700, Jeff Davis wrote:
> * Perhaps I'm mistaken, but the following code in getQuadrant() looks
> wrong to me, shouldn't the 1 and 2 be reversed?
>
> if (range_cmp_bounds(typcache, &upper, &centroidUpper) >= 0)
> return 1;
> else
> return 2;

Oops, looks like I was mistaken. The code looks fine to me now.

Regards,
Jeff Davis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-07-03 14:58:21 Re: User-Id Tracking when Portal was started
Previous Message Robert Haas 2012-07-03 13:57:07 Re: Posix Shared Mem patch