| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | "Gregory Stark" <stark(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Status of DISTINCT-by-hashing work |
| Date: | 2008-08-06 14:42:52 |
| Message-ID: | 13398.1218033772@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com> writes:
> Correct. I learned that method from nodeAgg. What I meant was that
> window functions reach for plan node and its sort keys through
> winstate->ss.ps. The mechanism is not ugly but some macros or exposed
> API seem more comfortable, especially if thinking about formulating
> window functions as user-defined functions.
Agreed, I was about to suggest the same thing. Have the window
functions pass the WindowState to some interface code that gets what
they need for them.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2008-08-06 14:55:16 | 8.3 planner ignore index with text_pattern_ops for eq |
| Previous Message | Hitoshi Harada | 2008-08-06 14:40:52 | Re: Status of DISTINCT-by-hashing work |