| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |
| Date: | 2012-02-09 18:30:27 |
| Message-ID: | 13361.1328812227@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012:
>> If people are sufficiently worried about this, a better answer would be
>> to teach the makefiles to run check_keywords.pl during every build.
> FWIW that script is throwing a warning here:
> Use of assignment to $[ is deprecated at /pgsql/source/HEAD/src/tools/check_keywords.pl line 19.
Any Perl hackers want to improve that script?
> Also, we should at least do the attached to simplify the process.
> +check:
> + $(top_srcdir)/src/tools/check_keywords.pl $(top_srcdir)
Actually, what would make sense in that line is to attach it to the
existing maintainer-check target, no? I don't think top-level
"make check" descends into this directory.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2012-02-09 23:14:41 | Re: pgsql: Have pg_receivexlog always send an invalid log position in statu |
| Previous Message | Alvaro Herrera | 2012-02-09 18:25:53 | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jesper Krogh | 2012-02-09 18:33:25 | Re: index-only quals vs. security_barrier views |
| Previous Message | Alvaro Herrera | 2012-02-09 18:25:53 | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |