Re: SerializeParamList vs machines with strict alignment

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, hlinnaka <hlinnaka(at)iki(dot)fi>
Subject: Re: SerializeParamList vs machines with strict alignment
Date: 2018-10-02 04:08:06
Message-ID: 13340.1538453286@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Tue, Oct 2, 2018 at 9:22 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> (I think we could drop the savepoint
>> too, no?)

> One advantage of keeping the savepoint is that we don't need to
> explicitly drop the objects which we have created temporarily for this
> test.

They'll go away anyway at the end of the transaction that the whole
script is wrapped in. (But it might be worth choosing slightly less
generic object names, to avoid a conflict against other sub-tests
later in that script.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-10-02 04:18:01 Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
Previous Message Amit Kapila 2018-10-02 04:03:55 Re: SerializeParamList vs machines with strict alignment