| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-22 21:11:09 |
| Message-ID: | 13328.1508706669@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> Sorry. Here it is.
This comment is neither correct nor intelligible:
/* important for value, key cannot being NULL */
I'd say just drop it.
The checks for "could not determine data type" errors seem
rather duplicative, too.
<compulsive-neatnik-ism>
The extern declaration seems to have been dropped in a rather
random place in the .h file.
</compulsive-neatnik-ism>
Looks good otherwise.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-22 22:03:13 | Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Previous Message | Andrew Dunstan | 2017-10-22 20:50:00 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Eric Ridge | 2017-10-22 21:19:58 | Re: How to determine that a TransactionId is really aborted? |
| Previous Message | Jaime Casanova | 2017-10-22 20:50:04 | Re: How to determine that a TransactionId is really aborted? |