Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ash M <makmarath(at)hotmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name
Date: 2019-02-10 22:39:19
Message-ID: 13325.1549838359@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> Updated patch attached again. This time due to a newly added call to
> LookupFuncName() in 1fb57af92.

Hmm ... I'd not looked at this before, but now that I do, the new API
for LookupFuncName seems mighty confused, or at least confusingly
documented. It's not clear what the combinations of the flags actually
do, or why you'd want to use them.

I wonder whether you'd be better off replacing the two bools with an
enum, or something like that.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Saul, Jean Paolo 2019-02-10 23:05:09 Re: BUG #15609: synchronous_commit=off insert performance regression with secondary indexes
Previous Message David Rowley 2019-02-10 22:05:54 Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-02-10 22:45:07 Re: dsa_allocate() faliure
Previous Message David Rowley 2019-02-10 22:05:54 Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name