Re: patch: autocomplete for functions

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: autocomplete for functions
Date: 2012-03-19 20:01:37
Message-ID: 1332187089-sup-8745@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Tom Lane's message of lun mar 19 16:53:49 -0300 2012:

> This connects somewhat to the discussions we've had in the past about
> trying to get not-intended-for-public-use functions out of the standard
> search path. Not that you want to put a full visibility check into the
> tab-completion query,

I'm rather of the contrary opinion -- surely if we're going to complete
function names, we should only complete those that are in schemas in the
path; similarly for column names. (BTW I didn't check but does this
completion work if I schema-qualify a column name?)

> but if it could simply exclude a "pg_private"
> namespace, that probably wouldn't be too expensive.

+1

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-03-19 20:05:33 Re: BUG #6510: A simple prompt is displayed using wrong charset
Previous Message Peter Eisentraut 2012-03-19 19:55:55 Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)