Re: Command Triggers, patch v11

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Thom Brown <thom(at)linux(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Subject: Re: Command Triggers, patch v11
Date: 2012-03-19 16:53:21
Message-ID: 1332176001.8435.1.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On sön, 2012-03-18 at 21:16 -0400, Tom Lane wrote:
> If we were going to change the output at all, I would vote for "CREATE
> TABLE nnnn" so as to preserve the rowcount functionality. Keep in
> mind though that this would force client-side changes, for instance in
> libpq's PQcmdTuples(). Fixing that one routine isn't so painful, but
> what of other client-side libraries, not to mention applications?

Doesn't seem worth it to me. At least, "SELECT nnnn" makes some sense:
nnnn rows were selected. "CREATE TABLE nnnn" means what? nnnn tables
were created?

What might make sense is to delegate this additional information to
separate fields in a future protocol revision.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-03-19 17:06:25 Re: Command Triggers, patch v11
Previous Message Robert Haas 2012-03-19 16:52:00 Re: Command Triggers, patch v11