| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Andrew Dunstan <adunstan(at)postgresql(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Joachim Wieland <joe(at)mcknight(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch for parallel pg_dump |
| Date: | 2012-03-14 20:56:37 |
| Message-ID: | 1331758470-sup-1260@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Andrew Dunstan's message of mié mar 14 17:39:59 -0300 2012:
> pgpipe used to be used in pgstat.c, but that's no longer true in any
> live branch, so it's probably long dead. I'd be inclined to rip it out
> if possible rather than expand its use.
our pgpipe() function is interesting -- all the callers that use it
first verify that they aren't WIN32. If they are, they are using a
#define that makes it plain pipe(). And the function is only defined in
WIN32. It seems a reasonable idea to kill both pgpipe() and piperead().
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2012-03-14 21:03:02 | Re: Faster compression, again |
| Previous Message | Robert Haas | 2012-03-14 20:53:58 | Re: wal_buffers, redux |