Re: review of: collation for (expr)

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Cc: probabble <probabble(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: review of: collation for (expr)
Date: 2012-03-02 19:20:06
Message-ID: 1330716006.11007.6.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tor, 2012-03-01 at 20:30 -0500, Jaime Casanova wrote:
> besides a clash in the oid and the value of leakproof missing in the
> pg_proc entry, everything works fine.

Fixed.

> The only thing is that i don't see a reason for these includes in
> src/backend/utils/adt/misc.c:
>
> + #include "nodes/nodeFuncs.h"
> + #include "utils/lsyscache.h"

lsyscache.h is necessary for type_is_collatable(), but the other was
probably left over from a previous attempt.

Committed with these changes.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-03-02 19:32:48 Re: 16-bit page checksums for 9.2
Previous Message Daniel Farina 2012-03-02 18:53:29 Re: Runtime SHAREDIR for testing CREATE EXTENSION