Re: Fixed pgAdmin3 issues/asserts

On Fri, 2012-03-02 at 13:49 +0530, Akshay Joshi wrote:
> Hi
>
> On Fri, Mar 2, 2012 at 4:47 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>
> On Thu, 2012-03-01 at 15:01 +0530, Akshay Joshi wrote:
> >
> >
> > On Thu, Mar 1, 2012 at 2:47 PM, Dave Page
> <dpage(at)pgadmin(dot)org> wrote:
> > Hi Akshay
> >
> >
> > On Thu, Mar 1, 2012 at 8:14 AM, Akshay Joshi
> > <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> > > Hi Guillaume
> > >
> > > On Thu, Mar 1, 2012 at 4:55 AM, Guillaume Lelarge
> > <guillaume(at)lelarge(dot)info>
> > > wrote:
> > >>
> > >> On Tue, 2012-02-28 at 09:21 +0100, Guillaume
> Lelarge wrote:
> > >> > On Tue, 2012-02-28 at 12:41 +0530, Akshay Joshi
> wrote:
> > >> > > Hi Guillaume/Dave
> > >> > >
> > >> > > On Tue, Feb 28, 2012 at 4:02 AM, Guillaume
> Lelarge
> > >> > > <guillaume(at)lelarge(dot)info> wrote:
> > >> > > On Mon, 2012-02-27 at 16:49 +0000,
> Dave Page
> > wrote:
> > >> > > > Thanks, applied.
> > >> > > >
> > >> > >
> > >> > > I probably have missed something. I
> thought the
> > work on 2.9
> > >> > > wasn't
> > >> > > finished. Are you able to compile
> with 2.9 on
> > Windows?
> > >> > >
> > >> > >
> > >> > > Yes, I am able to compile it with 2.9 on
> Windows. I
> > have created two
> > >> > > configurations Debug (2.9) and Release(2.9)
> where
> > wxWidgets libraries
> > >> > > gets changed from
> > >> > > 2.8 to 2.9. Attached is the patch which
> contain
> > changes in ".sln"
> > >> > > and ".vcproj" file.
> > >> > > For the work on 2.9 as concern, I have
> fixed
> > issues/asserts that I
> > >> > > have found. It is possible that there are
> many more
> > such
> > >> > > asserts/issues that we will have to fix.
> > >> > >
> > >> > > Dave, If patch looks good to you then can
> you please
> > commit it.
> > >> > >
> > >> >
> > >> > That's great. If your .sln/.vcproj files allow
> us to
> > still work on 2.8,
> > >> > I see no reason not to apply them. (I won't
> apply them
> > myself because I
> > >> > have no Windows PC right now to check them, but
> I guess
> > Dave will be
> > >> > able to do that quicker than me)
> > >> >
> > >>
> > >> I compiled 2.9 on my laptop, and compiled pgAdmin
> master
> > against it.
> > >> Compilation went fine, but I cannot start it. Did
> you also
> > build it on
> > >> Linux? and if so, does it work for you?
> > >
> > >
> > > I am facing the same issue on my Ubuntu
> machine. I got
> > segmentation fault
> > > with below mentioned error messages
> > >
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-CRITICAL **:
> g_once_init_leave:
> > assertion
> > > `initialization_value != 0' failed
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > g_type_add_interface_static:
> > > assertion `G_TYPE_IS_INSTANTIATABLE
> (instance_type)' failed
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > g_type_add_interface_static:
> > > assertion `G_TYPE_IS_INSTANTIATABLE
> (instance_type)' failed
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > g_type_add_interface_static:
> > > assertion `G_TYPE_IS_INSTANTIATABLE
> (instance_type)' failed
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-CRITICAL **:
> g_once_init_leave:
> > assertion
> > > `initialization_value != 0' failed
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > > /build/buildd/glib2.0-2.24.1/gobject/gtype.c:2706:
> You
> > forgot to call
> > > g_type_init()
> > > (process:3401): GLib-GObject-CRITICAL **:
> > g_type_add_interface_static:
> > > assertion `G_TYPE_IS_INSTANTIATABLE
> (instance_type)' failed
> > > (process:3401): GLib-CRITICAL **:
> g_once_init_leave:
> > assertion
> > > `initialization_value != 0' failed
> > > (process:3401): GLib-GObject-CRITICAL **:
> g_object_new:
> > assertion
> > > `G_TYPE_IS_OBJECT (object_type)' failed
> > > Segmentation fault
> > >
> > > I have googled but unable to find any solution.
> Will
> > working on the same.
> >
> >
> > Can you ping the wxWidgets list for help please?
> >
> >
> > Sure. It works on OSX and Windows, but not on Ubuntu. If
> anybody
> > have any idea on this please help.
> >
>
>
> I don't have much idea, but it seems to be related to
> http://www.wxwidgets.org/develop/standard.htm#no_globals
>
> Not sure how much help it is, but still, it might be worth the
> shot.
>
>
> Thanks Guillaume for sharing the link, it helps me. Yesterday I have
> posted the issue on wxWidgets forum and got the response that we have
> a wxFont instance
> as global or static variable somewhere in the code. Then I found
> wxFont instance as static variable in "hdFontAttribute.h". I have
> modified the code and try to fix
> the crash, it works for me.
>
> Attached is the patch file contains the fix. Please review it and If
> solution looks appropriate, then can you please commit it.
>

Nice patch. It works great for me. I'll apply it. Thank you very much.

I still have one issue because of an assert. I'll work on that later.

So, we do have pgAdmin compatible with wxWidgets 2.9. Can't wait to see
3.0 out. That would give us quite a lot of useful widgets to use.

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com