Re: Fixed pgAdmin3 issues/asserts

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed pgAdmin3 issues/asserts
Date: 2012-02-28 08:21:19
Message-ID: 1330417279.2246.1.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, 2012-02-28 at 12:41 +0530, Akshay Joshi wrote:
> Hi Guillaume/Dave
>
> On Tue, Feb 28, 2012 at 4:02 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> On Mon, 2012-02-27 at 16:49 +0000, Dave Page wrote:
> > Thanks, applied.
> >
>
> I probably have missed something. I thought the work on 2.9
> wasn't
> finished. Are you able to compile with 2.9 on Windows?
>
>
> Yes, I am able to compile it with 2.9 on Windows. I have created two
> configurations Debug (2.9) and Release(2.9) where wxWidgets libraries
> gets changed from
> 2.8 to 2.9. Attached is the patch which contain changes in ".sln"
> and ".vcproj" file.
> For the work on 2.9 as concern, I have fixed issues/asserts that I
> have found. It is possible that there are many more such
> asserts/issues that we will have to fix.
>
> Dave, If patch looks good to you then can you please commit it.
>

That's great. If your .sln/.vcproj files allow us to still work on 2.8,
I see no reason not to apply them. (I won't apply them myself because I
have no Windows PC right now to check them, but I guess Dave will be
able to do that quicker than me)

Thank you for your work.

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2012-02-28 13:40:12 pgAdmin III commit: Fix the handling of empty strings in the histoqueri
Previous Message Akshay Joshi 2012-02-28 07:11:17 Re: Fixed pgAdmin3 issues/asserts