| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Masahiko Sawada <msawada(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p |
| Date: | 2025-07-17 03:19:56 |
| Message-ID: | 1330026.1752722396@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Thu, 17 Jul 2025 at 02:56, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Looking again at the code for ereport_domain(), I wondered if
>> something like this would help MSVC see through it:
> I tried this and it unfortunately doesn't fix the issue.
I didn't have huge hopes for that, but thanks for checking.
> I spent a bit more time searching for a solution and did find
> something that works well enough for this case in [1]. Unfortunately,
> it only works with C11. See attached .c file and output below.
Hmph. I doubt we are ready to require C11 everywhere, but maybe
we could require it in MSVC builds? Which MSVC versions would
that eliminate?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-07-17 04:09:18 | Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p |
| Previous Message | David Rowley | 2025-07-17 00:52:07 | Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p |