improve line-breaking and indentation of foreign options dump

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: improve line-breaking and indentation of foreign options dump
Date: 2011-12-27 20:01:42
Message-ID: 1325016102.4642.3.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Currently, pg_dump dumps foreign options in a single line, for example

CREATE SERVER cluster FOREIGN DATA WRAPPER plproxy OPTIONS (p0 'host=host0', p1 'host=host1', p2 'host=host2', p3 'host=host3');

I think it would be nicer if it looked more like this:

CREATE SERVER cluster FOREIGN DATA WRAPPER plproxy OPTIONS (
p0 'host=host0',
p1 'host=host1',
p2 'host=host2',
p3 'host=host3'
);

Attached is a patch to implement that, and a test file to play around
with.

Attachment Content-Type Size
pg-foreign-options-formatting.patch text/x-patch 4.1 KB
pg-foreign-options-formatting-test.sql text/x-sql 562 bytes

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-12-27 20:04:32 Re: sorting table columns
Previous Message Jeff Davis 2011-12-27 19:24:07 Re: Page Checksums + Double Writes