| From: | Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, James Coleman <jtc331(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Use optimized single-datum tuplesort in ExecSort |
| Date: | 2021-07-15 14:53:29 |
| Message-ID: | 13249598.64SMogt8gv@aivenronan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le jeudi 15 juillet 2021, 16:19:23 CEST David Rowley a écrit :>
> Ronan's latest results plus John's make me think there's no need to
> separate out the node function as I did in v8. However, I do think v6
> could learn a little from v8. I think I'd rather see the sort method
> determined in ExecInitSort() rather than ExecSort(). I think
> minimising those few extra instructions in ExecSort() might help the
> L1 instruction cache.
>
I'm not sure I understand what you expect from moving that to ExecInitSort ?
Maybe we should also implement the tuplesort_state initialization in
ExecInitSort ? (not the actual feeding and sorting of course).
Please find attached a v9 just moving the flag setting to ExecInitSort, and my
apologies if I misunderstood your point.
--
Ronan Dunklau
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Allow-Sort-nodes-to-use-the-fast-single-datum-tuples.patch | text/x-patch | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2021-07-15 15:01:34 | Re: pg_upgrade does not upgrade pg_stat_statements properly |
| Previous Message | Andrey Lepikhov | 2021-07-15 14:49:11 | Re: Removing unneeded self joins |