| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | ertugrul9090(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15511: Drop table error "invalid argument" |
| Date: | 2019-02-05 11:28:44 |
| Message-ID: | 131ffaa0-0dbd-6da2-cdad-7757e234d0cb@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 07/12/2018 00:38, Tom Lane wrote:
> ... so my preliminary result is that there's a *boatload* of "invalid"
> format strings in our translation files, all of them apparently with
> the extra-space disease. See attached.
A bit of follow-up: I have committed fixes for all the erroneous uses
of space "flags" in translated format strings. These will then be in
the next minor releases.
I also looked into the gettext/msgfmt source code. We know that it does
check for format string compatibility, but I found that it only checks
the general type, not the formatting flags. I suppose this is not
unreasonable, since a translation might want to space or align something
differently. So we still don't have an easy way to check for this in
the future.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-02-05 14:11:32 | Re: Weird "could not determine which collation to use for string comparison" with LEAST/GREATEST on PG11 procedure |
| Previous Message | Saul, Jean Paolo | 2019-02-05 04:39:18 | Re: BUG #15609: synchronous_commit=off insert performance regression with secondary indexes |