| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Mr(dot) Aaron W(dot) Swenson <titanofold(at)gentoo(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug with pg_ctl -w/wait and config-only directories |
| Date: | 2011-10-03 19:08:16 |
| Message-ID: | 1317668814-sup-6101@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Bruce Momjian's message of lun oct 03 16:03:47 -0300 2011:
> > I'm not sure how big the overlap is - would it be easier if you moved
> > the required functionality into pg_upgrade itself, as you mentioned at
> > some point? As in, would it be easier to fix the config-only directory
> > case for the limited subset of functionality that pg_upgrade needs?
>
> Not really --- it is the -w/wait mode pg_upgrade needs. There is a lot
> of new code in pg_ctl that reads the postmaster.pid file for socket
> location, port number, etc, that doesn't make sense to duplicate.
> Frankly, there is the huge problem that they might specify the data
> directory on the command line --- that would be a bear to support.
How about creating a library with the controlling stuff that's shared by
pg_ctl and pg_upgrade?
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-10-03 19:09:08 | Re: Bug with pg_ctl -w/wait and config-only directories |
| Previous Message | Robert Haas | 2011-10-03 19:07:54 | Re: [REVIEW] pg_last_xact_insert_timestamp |