Re: Large C files

Excerpts from Bruce Momjian's message of sáb sep 03 20:18:47 -0300 2011:
> FYI, here are all the C files with over 6k lines:
>
> - 45133 ./interfaces/ecpg/preproc/preproc.c
> - 33651 ./backend/parser/gram.c
> - 17551 ./backend/parser/scan.c
> 14209 ./bin/pg_dump/pg_dump.c
> 10590 ./backend/access/transam/xlog.c
> 9764 ./backend/commands/tablecmds.c
> 8681 ./backend/utils/misc/guc.c
> - 7667 ./bin/psql/psqlscan.c
> 7213 ./backend/utils/adt/ruleutils.c
> 6814 ./backend/utils/adt/selfuncs.c
> 6176 ./backend/utils/adt/numeric.c
> 6030 ./pl/plpgsql/src/pl_exec.c
>
> I have dash-marked the files that are computer-generated. It seems
> pg_dump.c and xlog.c should be split into smaller C files.

I don't think there's any particular point to this general exercise (too
large for what?), but Simon had patches (or at least ideas) to split
xlog.c IIRC.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support