From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Allow pg_read_all_stats to read pg_stat_progress_* |
Date: | 2020-04-15 07:13:57 |
Message-ID: | 13145F2F-8458-4977-9D2D-7B2E862E5722@yandex-team.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi!
One of our users asked me why they cannot read details of pg_stat_progress_vacuum while they have pg_read_all_stats role.
Maybe I'm missing something, but I think they should be able to read stats...
PFA fix.
This affects pg_stat_progress_analyze, pg_stat_progress_basebackup, pg_stat_progress_cluster, pg_stat_progress_create_index and pg_stat_progress_vacuum.
With patch
postgres=# set role pg_read_all_stats ;
postgres=> select * from pg_stat_progress_vacuum ;
pid | datid | datname | relid | phase | heap_blks_total | heap_blks_scanned | heap_blks_vacuumed | index_vacuum_count | max_dead_tuples | num_dead_tuples
-------+-------+----------+-------+---------------+-----------------+-------------------+--------------------+--------------------+-----------------+-----------------
76331 | 12923 | postgres | 1247 | scanning heap | 10 | 1 | 0 | 0 | 2910 | 0
(1 row)
Without patch
postgres=# set role pg_read_all_stats ;
SET
postgres=> select * from pg_stat_progress_vacuum ;
pid | datid | datname | relid | phase | heap_blks_total | heap_blks_scanned | heap_blks_vacuumed | index_vacuum_count | max_dead_tuples | num_dead_tuples
-------+-------+----------+-------+-------+-----------------+-------------------+--------------------+--------------------+-----------------+-----------------
76331 | 12923 | postgres | | | | | | | |
(1 row)
Thanks!
Best regards, Andrey Borodin.
Attachment | Content-Type | Size |
---|---|---|
allow_read_all_stats.diff | application/octet-stream | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2020-04-15 07:18:42 | Parallel Append can break run-time partition pruning |
Previous Message | Michael Paquier | 2020-04-15 07:05:10 | Re: [patch] some PQExpBuffer are not destroyed in pg_dump |